Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken layers with pattern expressions #8833

Merged
merged 3 commits into from
Oct 3, 2019
Merged

fix broken layers with pattern expressions #8833

merged 3 commits into from
Oct 3, 2019

Conversation

ansis
Copy link
Contributor

@ansis ansis commented Oct 3, 2019

fix #8832

ResolvedImage was not registered for serialization. This registers it and fixes generation for a couple of codegen'd files. Adds a render test that throws without this fix.

Launch Checklist

  • briefly describe the changes in this PR
  • include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • manually test the debug page

ansis added 3 commits October 3, 2019 12:38
ResolvedImage was not registered for serialization. This registers it
and fixes a couple codegen'd files so that they generate properly.
@ansis ansis requested a review from ryanhamley October 3, 2019 17:00
@ansis ansis changed the title fix broken fill-pattern layers fix broken layers with pattern expressions Oct 3, 2019
Copy link
Contributor

@ryanhamley ryanhamley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the fix!

@ansis ansis merged commit b83e052 into master Oct 3, 2019
@ansis ansis deleted the fix-8832 branch October 3, 2019 18:22
@chloekraw chloekraw added this to the release-sangria milestone Oct 4, 2019
ryanhamley pushed a commit that referenced this pull request Oct 9, 2019
 fix #8832 broken fill pattern layers

ResolvedImage was not registered for serialization. This registers it
and fixes a couple codegen'd files so that they generate properly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

serialization error breaks pencil style
3 participants